Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using schedule #91

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Avoid using schedule #91

merged 1 commit into from
Apr 29, 2020

Conversation

nijel
Copy link
Contributor

@nijel nijel commented Apr 28, 2020

Execute task directly as there is already code taking care of the
delays.

Fixes #90

Maybe I missed something, but I see no reason of using additional scheduler, when the delays are already handled inside the code.

@nijel nijel mentioned this pull request Apr 28, 2020
Execute task directly as there is already code taking care of the
delays.

Fixes #90
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 75.598% when pulling 8bf8a84 on nijel:schedule into ae0555c on mtakaki:master.

@mtakaki
Copy link
Owner

mtakaki commented Apr 28, 2020

Codacy Here is an overview of what got changed by this pull request:

Coverage decreased per file
===========================
- cachet_url_monitor/scheduler.py  -2
         

See the complete overview on Codacy

@nijel
Copy link
Contributor Author

nijel commented Apr 28, 2020

@mtakaki Yes, some lines were removed, so the number of covered lines is lower as well.

@mtakaki
Copy link
Owner

mtakaki commented Apr 29, 2020

Thanks for submitting this, @nijel! Have you manually tested your change to ensure it still runs in the correct frequency? This isn't easy to test through unit test.

@nijel
Copy link
Contributor Author

nijel commented Apr 29, 2020

It runs fine for me. It's powering https://cachet.weblate.org/

@mtakaki
Copy link
Owner

mtakaki commented Apr 29, 2020

Sounds good to me!

@mtakaki mtakaki merged commit 21063d6 into mtakaki:master Apr 29, 2020
@nijel nijel deleted the schedule branch April 29, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring executed several times
3 participants