Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiline support (updated) #110

Merged
merged 9 commits into from
May 29, 2024
Merged

Conversation

jon-v2
Copy link
Collaborator

@jon-v2 jon-v2 commented May 9, 2024

No description provided.

@jon-v2 jon-v2 linked an issue May 9, 2024 that may be closed by this pull request
@jon-v2 jon-v2 requested a review from daretodave May 9, 2024 20:44
@daretodave
Copy link
Contributor

daretodave commented May 9, 2024

  • when we scroll back to the prior command that was broken up -> we are in a single-line mode again
    • im okay with this, but i wonder is there any quick fix to make it scroll back up to make it break up again
      • steps to repro: run a multi-line arg, then hit up to go back to it
  • when we shift enter in an existing single line, we break at the end vs. where the cursor is
    • im okay with this too. but i wonder if there is any quick fix to separate at cursor and move the right chunk to the multi-line
      • steps to repo: write test --this --command without any shift enter, then move the cursor to after test and hit shift enter -> there is no break as expected
  • when we go up and down history we see the existing multiline arg from the prior attempt, this should clear
  • remove justify-content: space-around to get our input to center vertically, that was my bad from the original implementation

@daretodave
Copy link
Contributor

daretodave commented May 9, 2024

this is 🔥 🔥 🔥 🔥 🔥 🔥 lets just get the third and forth one addressed at least, other two can wait for future

Copy link
Contributor

@daretodave daretodave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@mterm-io mterm-io deleted a comment from mterm-robot May 19, 2024
@daretodave daretodave merged commit aabc215 into main May 29, 2024
2 checks passed
@daretodave daretodave deleted the fix-multiline-support-(updated) branch May 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solving multiline - transform prompt to prompt chain
2 participants