Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up components logic and typings #583

Closed
staghouse opened this issue Feb 13, 2023 · 0 comments · Fixed by #584
Closed

Clean up components logic and typings #583

staghouse opened this issue Feb 13, 2023 · 0 comments · Fixed by #584
Assignees
@staghouse
Labels
Technical Debt Technical changes that do not generally affect the end-user

Comments

@staghouse
Copy link
Member

Some of the logic is a bit dated in some places and could be cleaned up. Also after looking deeper there is some TS type mismatches that should be addressed.
@staghouse staghouse added the Technical Debt Technical changes that do not generally affect the end-user label Feb 13, 2023
@staghouse staghouse self-assigned this Feb 13, 2023
@staghouse staghouse mentioned this issue Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staghouse staghouse

Labels
Technical Debt Technical changes that do not generally affect the end-user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue/583: Code clean up, typing fixes and misc changes. mtgjson/mtgjson-website
1 participant
@staghouse