Fixed version restore behaviour when executing 'poetry run' commands on Linux with poetry >= 1.0.0b2 #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
as of version 1.0.0b2, on Linux, the
poetry run
command usesos.execvp
function instead of spawning a new subprocess.For poetry-dynamic-versioning this change has the side-effect that the
atexit
hook is no longer called and, as a consequence, the original version string inpyproject.toml
is not properly restored.The proposed solution is to also patch
poetry.console.command.run.RunCommand.handle
function in order to immediately calldeactivate
before executing the desired command/script.