Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version is empty string #558

Closed
kovmir opened this issue Mar 3, 2024 · 1 comment · Fixed by #559
Closed

Version is empty string #558

kovmir opened this issue Mar 3, 2024 · 1 comment · Fixed by #559

Comments

@kovmir
Copy link

kovmir commented Mar 3, 2024

Using 1.4.2, downloaded binary from GitHub assets. If I go to System -> Information, there is nothing after Version: at the bottom of the page, but there is a timestamp right after Built at:.
@mtlynch mtlynch mentioned this issue Mar 3, 2024
Merged
mtlynch added a commit that referenced this issue Mar 3, 2024
@mtlynch
Store the PicoShare version number in the release binaries (#559)
dcfb01a 
Resolves #558 

I forgot to include the `PS_VERSION` Docker build arg when building the
release binaries, which caused the version displayed in the web app to
be empty. Adding the proper arg should fix the issue.
@mtlynch
Copy link
Owner

mtlynch commented Mar 3, 2024

@kovmir - Thanks for reporting this! Should be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store the PicoShare version number in the release binaries mtlynch/picoshare
2 participants
@mtlynch @kovmir