Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cliff for CLI layer #62

Closed
mtreinish opened this issue May 25, 2017 · 8 comments
Closed

Use cliff for CLI layer #62

mtreinish opened this issue May 25, 2017 · 8 comments
Assignees
@masayukig
Labels
enhancement help wanted

Comments

@mtreinish
Copy link
Owner

The cliff project (https://pypi.python.org/pypi/cliff )provides a lot of advantages for a cli with subcommands like stestr. Instead of just using argparse we should leverage cliff to provide a more polished CLI experience.
@mtreinish
Copy link
Owner Author

There might actually be more of a tradeoff here than I originally thought. It is probably worth thoroughly investigating this first to see what the overhead is first. If we can maintain backwards compatibility and don't take a noticeable performance hit then it's probably worth the migration. But, if that's not the case then we should just stick with what's there now I guess.

@masayukig
Copy link
Collaborator

I'm actually not sure the overhead, either. But I think it's worth a try :)

@chkumar246
Copy link
Contributor

@masayukig @mtreinish I will take this issue.

@masayukig
Copy link
Collaborator

@chkumar246 Are you still thinking to do for this? If not, I'll take this.

@chkumar246
Copy link
Contributor

@masayukig Feel free to take it.

@masayukig
Copy link
Collaborator

Thanks! I'll do :)

@masayukig masayukig self-assigned this Sep 20, 2017
masayukig added a commit to masayukig/stestr that referenced this issue Sep 21, 2017
@masayukig
[WIP] Use cliff for CLI layer
5344c4e 
This commit makes stestr use cliff for CLI layer.

MEMO
* Just run command is implemented, so far.

TODO
* Implement failing, init, last, list, load, slowest
* Add more tests?

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Sep 21, 2017
@masayukig
[WIP] Use cliff for CLI layer
e570301 
This commit makes stestr use cliff for CLI layer.

MEMO
* Just run command is implemented, so far.

TODO
* Implement failing, init, last, list, load, slowest
* Add more tests?

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Sep 22, 2017
@masayukig
[WIP] Use cliff for CLI layer
cad43f9 
This commit makes stestr use cliff for CLI layer.

MEMO
* Just run command is implemented, so far.

TODO
* Implement failing, init, last, list, load, slowest
* Add more tests?

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Sep 22, 2017
@masayukig
Use cliff for CLI layer
3adfba6 
This commit makes stestr use cliff for CLI layer.

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Sep 22, 2017
@masayukig
Use cliff for CLI layer
b83be5a 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more plished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
@masayukig masayukig mentioned this issue Sep 22, 2017
Merged
masayukig added a commit to masayukig/stestr that referenced this issue Sep 22, 2017
@masayukig
Use cliff for CLI layer
893f53f 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more plished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Oct 18, 2017
@masayukig
Use cliff for CLI layer
866da67 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more plished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Oct 26, 2017
@masayukig
Use cliff for CLI layer
f86bd2f 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more plished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Oct 26, 2017
@masayukig
Use cliff for CLI layer
da37b84 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more plished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Oct 27, 2017
@masayukig
Use cliff for CLI layer
e17f252 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more plished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
masayukig added a commit to masayukig/stestr that referenced this issue Oct 27, 2017
@masayukig
Use cliff for CLI layer
e55b5eb 
This commit makes stestr use cliff[1] for CLI layer. The cliff project
provides a lot of advantages for stestr cli which has subcommands.
Instead of just using argparse, we should leverage cliff to provide a
more polished CLI experience.

[1] https://pypi.python.org/pypi/cliff

Closes Issue mtreinish#62
@masayukig
Copy link
Collaborator

I think this can be closed with #100 merging now.

@mtreinish
Copy link
Owner Author

Yep, we're using cliff now so let's close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masayukig masayukig

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@masayukig @mtreinish @chkumar246