Running with --subunit flag always returns 0 #68
Labels
Comments
mtreinish
added a commit
that referenced
this issue
Jul 26, 2017
The --subunit flag on stestr run, load, etc always returns 0. This is done primarily to ensure that subunit processing can happen without issue, especially from inside a python caller. (there is also an implicit assumption that if you emit subunit whatever consumes that will check for the failure condition and handle that itself) This has a side effect for the --until-failure flag on stestr run which will never exit if --subunit is used because there is never a failure condition detected because subunit output always returns 0. This commit fixes this by checking the repository directly for failure if --subunit and --until-failure are used together. Closes Issue #68
mtreinish
added a commit
that referenced
this issue
Jul 26, 2017
The --subunit flag on stestr run, load, etc always returns 0. This is done primarily to ensure that subunit processing can happen without issue, especially from inside a python caller. (there is also an implicit assumption that if you emit subunit whatever consumes that will check for the failure condition and handle that itself) This has a side effect for the --until-failure flag on stestr run which will never exit if --subunit is used because there is never a failure condition detected because subunit output always returns 0. This commit fixes this by checking the repository directly for failure if --subunit and --until-failure are used together. Closes Issue #68
mtreinish
added a commit
that referenced
this issue
Jul 26, 2017
The --subunit flag on stestr run, load, etc always returns 0. This is done primarily to ensure that subunit processing can happen without issue, especially from inside a python caller. (there is also an implicit assumption that if you emit subunit whatever consumes that will check for the failure condition and handle that itself) This has a side effect for the --until-failure flag on stestr run which will never exit if --subunit is used because there is never a failure condition detected because subunit output always returns 0. This commit fixes this by checking the repository directly for failure if --subunit and --until-failure are used together. Closes Issue #68
mtreinish
added a commit
that referenced
this issue
Jul 27, 2017
The --subunit flag on stestr run, load, etc always returns 0. This is done primarily to ensure that subunit processing can happen without issue, especially from inside a python caller. (there is also an implicit assumption that if you emit subunit whatever consumes that will check for the failure condition and handle that itself) This has a side effect for the --until-failure flag on stestr run which will never exit if --subunit is used because there is never a failure condition detected because subunit output always returns 0. This commit fixes this by checking the repository directly for failure if --subunit and --until-failure are used together. Closes Issue #68
|
With #69 merged this bug is closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you run stestr run with the --subunit flag the return code is always 0, even if tests fail. stestr run should return a 1 on failed tests. This causes the--until-failure flag to loop forever if running with --subunit. This is a bug carried over from testrepository in: https://bugs.launchpad.net/testrepository/+bug/1411804
The text was updated successfully, but these errors were encountered: