Fix error handling for unknown arguments #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes to handle unknown arguments. Unknown arguments should be treated as fatal. Otherwise, users can't know their options are valid or not at the runtime. Fixes issue mtreinish#99
|
@masayukig This looks fine to me, but did you want to land this to fix #99 for the next release? I thought you were planning to just fix this with the cliff migration in #100 (which btw has the best commit number) |
|
Ah, I'm fine with fixing this with the cliff migration :) yeah, I agree with the commit number is the best. |
|
well, I was thinking just abandon this, and wait for 1.1.0. I actually don't know how to abandon, though.. |
|
ah, I found that this "Close and comment" button is for it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes to handle unknown arguments. Unknown arguments should
be treated as fatal. Otherwise, users can't know their options are valid
or not at the runtime.
Fixes issue #99