Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 tests failed #46

Open
ForbesLindesay opened this issue Jan 2, 2013 · 4 comments
Open

IE8 tests failed #46

ForbesLindesay opened this issue Jan 2, 2013 · 4 comments

Comments

@ForbesLindesay
Copy link

I get the following error when I attempt to run the tests in ie8

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; .NET CLR 1.1.4322)
Timestamp: Wed, 2 Jan 2013 23:20:02 UTC


Message: Object expected
Line: 180
Char: 21
Code: 0
URI: /path.js
@emoods
Copy link

emoods commented Jan 16, 2013

I fixed this issue by changing line 180 to:

result = Path.routes.defined[this.path].do_enter[i].apply(this);

in the minified version, this bug is solved by the minifier :-)

@ForbesLindesay
Copy link
Author

That worked, build status before your change:

build status

Build status after that change:

build status

It still fails on 7 mind you.

@emoods
Copy link

emoods commented Jan 17, 2013

IE7 is not a browser ;-)

@ForbesLindesay
Copy link
Author

True, but I test all the way down to IE6 on my new continuous integration service (https://jepso-ci.com)

skovhus pushed a commit to skovhus/pathjs that referenced this issue Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants