Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Use a pup fork to make mac installer compatible with OS X 10.12. #2371

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

carlosperate
Copy link
Member

@carlosperate carlosperate commented Dec 13, 2022

Uses a proof of concept fork to see if it can create a macOS installer with wheels compatible with older macOS versions, 10.12+.

This is to test a possible solution to:

And the proof-of-concept PR in the pup repo that shows the difference between this fork and pup:

@carlosperate
Copy link
Member Author

I can confirm the macOS installer from this PR works in OS X 10.12.

If the next Mu release comes before this feature lands in pup we might want to temporarily merge this PR and create the installers from this fork. We can always reverted back once pup has this functionality.

@carlosperate
Copy link
Member Author

Merging this PR with the temporal workaround will also resolve issue:

Which was tested in Mu with PR:

@carlosperate
Copy link
Member Author

We'll merge this PR to be able to release Mu v1.2.1 with fixes for these two issues:

I've created this issue to remember to remove this workaround once pup has incorporated upstream fixes for those issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant