Refactor i18n #389
Merged
Refactor i18n #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f making mu.logic able to be imported independently
| @@ -1483,3 +1484,19 @@ def test_rename_tab_avoid_duplicating_other_tab_name(): | |||
| 'A file of that name is already ' | |||
| 'open in Mu.') | |||
| assert mock_tab.path == 'old.py' | |||
|
|
|||
| def test_logic_independent_import_logic(): | |||
There was a problem hiding this comment.
Looks like pystyle is complaining about not having 2 blank lines between functions: E302 expected 2 blank lines, found 1.
Same for the one below.
There was a problem hiding this comment.
(Sigh; once again a reply hasn't made it through to GH)
Thanks; good catch. In short: I didn't run make check. I'll go back and rejig.
BTW I've never encountered a codebase which actually puts two blank lines between functions (except possibly to mollify nagging linters...)
|
Thank you. I fixed the style issue before merging. ;-) You mention not seeing the two line convention... These past few years, I've seen nothing but this convention. C'est la vie. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the small refactor of the i18n / gettext support so that it's part of the package import. Apart from a bit of tidiness, this means: