-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for encodings #390
Conversation
…nd newlines This adds supprting code and tests for that code but doesn't touch the existing Mu implementation
Hold until I run and sort out make check |
@tjguk this is great..! Please do let me know when I can check/merge. You mention more intrusive upcoming changes. What might they be? |
Hi @tjguk, could the tests in |
Certainly. The reasons for the move were twofold: one was, as you suggest, to prevent test_logic from becoming even bigger. But the principal one was because of the conflicts I'd experienced the previous time round. I'll bring them back in now. Meanwhile: can you see what Appveyor is complaining about? I can't. |
… requests. (They were previously held separately partly to keep the size of test_logic.py down but principally to avoid messy merge conflicts at a time when the pace of change to logic.py was greater)
Thank you! :-) Appveyor shouldn't complain now... I fixed the problem in master. |
This support adds testing & functional support for reading & writing Mu files with encodings and line-endings. But it does not actually integrate that functionality in the current Mu codebase. With the pace of change in the codebase at the moment I found myself mired in push races and merge conflicts. So this does the minimum possible to get the support in now, ready for the more intrusive changes afterwards.
This will supersede #370