Fix improper uses of reinterpret_cast #2382
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many instances where a class is inappropriately
reinterpret_cast
'd to a subclass. Astatic_cast
should be used to verify they are in fact convertible types.There are also instances where a void* is inappropriately
reinterpret_cast
'd.static_cast
should be used withvoid*
becausevoid*
is universally convertible.Further reading: https://en.cppreference.com/w/cpp/language/static_cast