-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: replace shell pwd in Makefile with CURDIR for better windows compatibility #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai canceled.
|
dionysius
changed the title
replace shell pwd in Makefile with CURDIR
minor: replace shell pwd in Makefile with CURDIR
Jan 10, 2024
dionysius
changed the title
minor: replace shell pwd in Makefile with CURDIR
minor: replace shell pwd in Makefile with CURDIR for better windows compatibility
Jan 10, 2024
mudler
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, good catch, thanks @dionysius !
truecharts-admin
referenced
this pull request
in truecharts/public
Jan 21, 2024
….0 by renovate (#17442) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | minor | `v2.5.1-cublas-cuda11-ffmpeg-core` -> `v2.6.0-cublas-cuda11-ffmpeg-core` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>mudler/LocalAI (docker.io/localai/localai)</summary> ### [`v2.6.0`](https://togithub.com/mudler/LocalAI/releases/tag/v2.6.0) [Compare Source](https://togithub.com/mudler/LocalAI/compare/v2.5.1...v2.6.0) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### Bug fixes 🐛 - move BUILD_GRPC_FOR_BACKEND_LLAMA logic to makefile: errors in this section now immediately fail the build by [@​dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1576](https://togithub.com/mudler/LocalAI/pull/1576) - prepend built binaries in PATH for BUILD_GRPC_FOR_BACKEND_LLAMA by [@​dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1593](https://togithub.com/mudler/LocalAI/pull/1593) ##### Exciting New Features 🎉 - minor: replace shell pwd in Makefile with CURDIR for better windows compatibility by [@​dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1571](https://togithub.com/mudler/LocalAI/pull/1571) - Makefile: allow to build without GRPC_BACKENDS by [@​mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1607](https://togithub.com/mudler/LocalAI/pull/1607) - feat: 🐍 add mamba support by [@​mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1589](https://togithub.com/mudler/LocalAI/pull/1589) - feat(extra-backends): Improvements, adding mamba example by [@​mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1618](https://togithub.com/mudler/LocalAI/pull/1618) ##### 👒 Dependencies - ⬆️ Update docs version mudler/LocalAI by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1567](https://togithub.com/mudler/LocalAI/pull/1567) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1568](https://togithub.com/mudler/LocalAI/pull/1568) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1573](https://togithub.com/mudler/LocalAI/pull/1573) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1578](https://togithub.com/mudler/LocalAI/pull/1578) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1583](https://togithub.com/mudler/LocalAI/pull/1583) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1587](https://togithub.com/mudler/LocalAI/pull/1587) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1590](https://togithub.com/mudler/LocalAI/pull/1590) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1594](https://togithub.com/mudler/LocalAI/pull/1594) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1599](https://togithub.com/mudler/LocalAI/pull/1599) ##### Other Changes - Moving the how tos to self hosted by [@​lunamidori5](https://togithub.com/lunamidori5) in [https://github.com/mudler/LocalAI/pull/1574](https://togithub.com/mudler/LocalAI/pull/1574) - docs: missing golang requirement for local build for debian by [@​dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1596](https://togithub.com/mudler/LocalAI/pull/1596) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1597](https://togithub.com/mudler/LocalAI/pull/1597) - docs/examples: enhancements by [@​mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1572](https://togithub.com/mudler/LocalAI/pull/1572) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1604](https://togithub.com/mudler/LocalAI/pull/1604) - Update README.md by [@​lunamidori5](https://togithub.com/lunamidori5) in [https://github.com/mudler/LocalAI/pull/1601](https://togithub.com/mudler/LocalAI/pull/1601) - docs: re-use original permalinks by [@​mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1610](https://togithub.com/mudler/LocalAI/pull/1610) - ⬆️ Update ggerganov/llama.cpp by [@​localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1612](https://togithub.com/mudler/LocalAI/pull/1612) - Expanded and interlinked Docker documentation by [@​jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/mudler/LocalAI/pull/1614](https://togithub.com/mudler/LocalAI/pull/1614) - Modernized LlamaIndex integration by [@​jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/mudler/LocalAI/pull/1613](https://togithub.com/mudler/LocalAI/pull/1613) ##### New Contributors - [@​dionysius](https://togithub.com/dionysius) made their first contribution in [https://github.com/mudler/LocalAI/pull/1571](https://togithub.com/mudler/LocalAI/pull/1571) **Full Changelog**: mudler/LocalAI@v2.5.1...v2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
discretizer
referenced
this pull request
in discretizer/charts
Jan 29, 2024
….0 by renovate (truecharts#17442) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | minor | `v2.5.1-cublas-cuda11-ffmpeg-core` -> `v2.6.0-cublas-cuda11-ffmpeg-core` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>mudler/LocalAI (docker.io/localai/localai)</summary> ### [`v2.6.0`](https://togithub.com/mudler/LocalAI/releases/tag/v2.6.0) [Compare Source](https://togithub.com/mudler/LocalAI/compare/v2.5.1...v2.6.0) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### Bug fixes 🐛 - move BUILD_GRPC_FOR_BACKEND_LLAMA logic to makefile: errors in this section now immediately fail the build by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1576](https://togithub.com/mudler/LocalAI/pull/1576) - prepend built binaries in PATH for BUILD_GRPC_FOR_BACKEND_LLAMA by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1593](https://togithub.com/mudler/LocalAI/pull/1593) ##### Exciting New Features 🎉 - minor: replace shell pwd in Makefile with CURDIR for better windows compatibility by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1571](https://togithub.com/mudler/LocalAI/pull/1571) - Makefile: allow to build without GRPC_BACKENDS by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1607](https://togithub.com/mudler/LocalAI/pull/1607) - feat: 🐍 add mamba support by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1589](https://togithub.com/mudler/LocalAI/pull/1589) - feat(extra-backends): Improvements, adding mamba example by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1618](https://togithub.com/mudler/LocalAI/pull/1618) ##### 👒 Dependencies - ⬆️ Update docs version mudler/LocalAI by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1567](https://togithub.com/mudler/LocalAI/pull/1567) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1568](https://togithub.com/mudler/LocalAI/pull/1568) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1573](https://togithub.com/mudler/LocalAI/pull/1573) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1578](https://togithub.com/mudler/LocalAI/pull/1578) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1583](https://togithub.com/mudler/LocalAI/pull/1583) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1587](https://togithub.com/mudler/LocalAI/pull/1587) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1590](https://togithub.com/mudler/LocalAI/pull/1590) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1594](https://togithub.com/mudler/LocalAI/pull/1594) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1599](https://togithub.com/mudler/LocalAI/pull/1599) ##### Other Changes - Moving the how tos to self hosted by [@&truecharts#8203;lunamidori5](https://togithub.com/lunamidori5) in [https://github.com/mudler/LocalAI/pull/1574](https://togithub.com/mudler/LocalAI/pull/1574) - docs: missing golang requirement for local build for debian by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1596](https://togithub.com/mudler/LocalAI/pull/1596) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1597](https://togithub.com/mudler/LocalAI/pull/1597) - docs/examples: enhancements by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1572](https://togithub.com/mudler/LocalAI/pull/1572) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1604](https://togithub.com/mudler/LocalAI/pull/1604) - Update README.md by [@&truecharts#8203;lunamidori5](https://togithub.com/lunamidori5) in [https://github.com/mudler/LocalAI/pull/1601](https://togithub.com/mudler/LocalAI/pull/1601) - docs: re-use original permalinks by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1610](https://togithub.com/mudler/LocalAI/pull/1610) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1612](https://togithub.com/mudler/LocalAI/pull/1612) - Expanded and interlinked Docker documentation by [@&truecharts#8203;jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/mudler/LocalAI/pull/1614](https://togithub.com/mudler/LocalAI/pull/1614) - Modernized LlamaIndex integration by [@&truecharts#8203;jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/mudler/LocalAI/pull/1613](https://togithub.com/mudler/LocalAI/pull/1613) ##### New Contributors - [@&truecharts#8203;dionysius](https://togithub.com/dionysius) made their first contribution in [https://github.com/mudler/LocalAI/pull/1571](https://togithub.com/mudler/LocalAI/pull/1571) **Full Changelog**: mudler/LocalAI@v2.5.1...v2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
GabrielBarzen
referenced
this pull request
in GabrielBarzen/charts
Feb 2, 2024
….0 by renovate (truecharts#17442) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/localai/localai](https://togithub.com/mudler/LocalAI) | minor | `v2.5.1-cublas-cuda11-ffmpeg-core` -> `v2.6.0-cublas-cuda11-ffmpeg-core` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>mudler/LocalAI (docker.io/localai/localai)</summary> ### [`v2.6.0`](https://togithub.com/mudler/LocalAI/releases/tag/v2.6.0) [Compare Source](https://togithub.com/mudler/LocalAI/compare/v2.5.1...v2.6.0) <!-- Release notes generated using configuration in .github/release.yml at master --> ##### What's Changed ##### Bug fixes 🐛 - move BUILD_GRPC_FOR_BACKEND_LLAMA logic to makefile: errors in this section now immediately fail the build by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1576](https://togithub.com/mudler/LocalAI/pull/1576) - prepend built binaries in PATH for BUILD_GRPC_FOR_BACKEND_LLAMA by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1593](https://togithub.com/mudler/LocalAI/pull/1593) ##### Exciting New Features 🎉 - minor: replace shell pwd in Makefile with CURDIR for better windows compatibility by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1571](https://togithub.com/mudler/LocalAI/pull/1571) - Makefile: allow to build without GRPC_BACKENDS by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1607](https://togithub.com/mudler/LocalAI/pull/1607) - feat: 🐍 add mamba support by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1589](https://togithub.com/mudler/LocalAI/pull/1589) - feat(extra-backends): Improvements, adding mamba example by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1618](https://togithub.com/mudler/LocalAI/pull/1618) ##### 👒 Dependencies - ⬆️ Update docs version mudler/LocalAI by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1567](https://togithub.com/mudler/LocalAI/pull/1567) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1568](https://togithub.com/mudler/LocalAI/pull/1568) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1573](https://togithub.com/mudler/LocalAI/pull/1573) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1578](https://togithub.com/mudler/LocalAI/pull/1578) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1583](https://togithub.com/mudler/LocalAI/pull/1583) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1587](https://togithub.com/mudler/LocalAI/pull/1587) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1590](https://togithub.com/mudler/LocalAI/pull/1590) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1594](https://togithub.com/mudler/LocalAI/pull/1594) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1599](https://togithub.com/mudler/LocalAI/pull/1599) ##### Other Changes - Moving the how tos to self hosted by [@&truecharts#8203;lunamidori5](https://togithub.com/lunamidori5) in [https://github.com/mudler/LocalAI/pull/1574](https://togithub.com/mudler/LocalAI/pull/1574) - docs: missing golang requirement for local build for debian by [@&truecharts#8203;dionysius](https://togithub.com/dionysius) in [https://github.com/mudler/LocalAI/pull/1596](https://togithub.com/mudler/LocalAI/pull/1596) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1597](https://togithub.com/mudler/LocalAI/pull/1597) - docs/examples: enhancements by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1572](https://togithub.com/mudler/LocalAI/pull/1572) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1604](https://togithub.com/mudler/LocalAI/pull/1604) - Update README.md by [@&truecharts#8203;lunamidori5](https://togithub.com/lunamidori5) in [https://github.com/mudler/LocalAI/pull/1601](https://togithub.com/mudler/LocalAI/pull/1601) - docs: re-use original permalinks by [@&truecharts#8203;mudler](https://togithub.com/mudler) in [https://github.com/mudler/LocalAI/pull/1610](https://togithub.com/mudler/LocalAI/pull/1610) - ⬆️ Update ggerganov/llama.cpp by [@&truecharts#8203;localai-bot](https://togithub.com/localai-bot) in [https://github.com/mudler/LocalAI/pull/1612](https://togithub.com/mudler/LocalAI/pull/1612) - Expanded and interlinked Docker documentation by [@&truecharts#8203;jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/mudler/LocalAI/pull/1614](https://togithub.com/mudler/LocalAI/pull/1614) - Modernized LlamaIndex integration by [@&truecharts#8203;jamesbraza](https://togithub.com/jamesbraza) in [https://github.com/mudler/LocalAI/pull/1613](https://togithub.com/mudler/LocalAI/pull/1613) ##### New Contributors - [@&truecharts#8203;dionysius](https://togithub.com/dionysius) made their first contribution in [https://github.com/mudler/LocalAI/pull/1571](https://togithub.com/mudler/LocalAI/pull/1571) **Full Changelog**: mudler/LocalAI@v2.5.1...v2.6.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a bit of compatibility for windows (#1569). go mod doesn't like the returned path of pwd in the replace directive by injecting double absolute paths resulting in not finding the correct folder.
Secondly added
"
around the PATH since windows likes to have spaces and brackets (brackets actually break it) at: https://github.com/mudler/LocalAI/pull/1571/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R473Notes for Reviewers
make's
$(CURDIR)
should yield the same result as$(shell pwd)
and thus the behaviour should still be the same for unixoide systems. Other places in the makefile are also updated as IMO it doesn't make sense to keep two different variants.Signed commits