Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(arm64): fix llama.cpp build by adding googletest to CMakefile #2757

Closed
wants to merge 3 commits into from

Conversation

mudler
Copy link
Owner

@mudler mudler commented Jul 9, 2024

Seems one more is required (see #2754)

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 9080e64
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/668da857393a290008ef6967
😎 Deploy Preview https://deploy-preview-2757--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler and others added 2 commits July 9, 2024 23:12
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
@dave-gray101
Copy link
Collaborator

dave-gray101 commented Jul 9, 2024

@mudler I'm looking at https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md#running-abseil-tests-with-cmake more closely, and it looks like there's two approaches here. We can either make abseil download the test dependencies... or see if we can skip testing abseil with the other flag. I'll try the latter in a separate PR, since I can't imagine we need to be running the abseil test suite in our pipeline - but if we do need to, try removing the manual download and using -DABSL_USE_GOOGLETEST_HEAD as documented on that link?

Edit: It's still in progress, but #2758 is already past the point we seem to be getting stuck on. Unless you can think of a good reason to actually care about Abseil's test cases as a part of our CI pipeline, I think that PR will obsolete this one.

Edit 2: #2758 is past all the arm-related steps and is just working through the usual suspects. I think it's safe to say we can just disable running these tests for now - we are not patching abseil with custom code or anything, so we should have "herd immunity" from the many other projects who use this standardized library. The gRPC build / tests will end up exercising the portions we need anyway!

@mudler
Copy link
Owner Author

mudler commented Jul 10, 2024

Closing this, thanks @dave-gray101 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants