Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Deps once when compiling concurrently #7

Closed
mudler opened this issue Nov 12, 2019 · 0 comments
Closed

Resolve Deps once when compiling concurrently #7

mudler opened this issue Nov 12, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mudler
Copy link
Owner

mudler commented Nov 12, 2019

As per comment in:

luet/pkg/compiler/compiler.go

Line 192 in 5ee610f

err := cs.Tree().ResolveDeps(concurrency) // FIXME: When done in parallel, this could be done on top before starting

We need to move out the resolvedeps step up when calling it in parallel, otherwise each thread will do the same job.
@mudler mudler added the good first issue Good for newcomers label Nov 12, 2019
mudler added a commit that referenced this issue Nov 15, 2019
@mudler
Make DB Switchable
6f7e63e 
Fixes races conditions and make the DB Switchable. Also prepare inside
the CompilationSpec the tree of the deps to be built, and parallelize
only the building jobs.

Closes #7
@mudler mudler closed this as completed in b2060c8 Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mudler