-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part name construction for devices like mmcblk0p1 and nvme0n1p1 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of: kairos-io/kairos#1831 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
force-pushed
the
fix-part-name
branch
from
September 18, 2023 13:55
5f86198
to
7b21f95
Compare
jimmykarily
commented
Sep 18, 2023
jimmykarily
added a commit
to kairos-io/kairos-agent
that referenced
this pull request
Sep 22, 2023
to get this fix: mudler/yip#110 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to kairos-io/immucore
that referenced
this pull request
Sep 22, 2023
to get this fix: mudler/yip#110 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
mauromorales
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jimmykarily
added a commit
to kairos-io/kairos-agent
that referenced
this pull request
Sep 25, 2023
to get this fix: mudler/yip#110 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to kairos-io/immucore
that referenced
this pull request
Sep 25, 2023
to get this fix: mudler/yip#110 as part of this: kairos-io/kairos#1831 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily
added a commit
to kairos-io/immucore
that referenced
this pull request
Sep 25, 2023
* Add awk and gawk in the initrafms to allow growpart to work. Also include libraries which dracut fails to auto-detect Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Bump yip to get this fix: mudler/yip#110 as part of this: kairos-io/kairos#1831 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Fix lint errors Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> --------- Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Itxaka
pushed a commit
to kairos-io/immucore
that referenced
this pull request
Sep 26, 2023
* Add awk and gawk in the initrafms to allow growpart to work. Also include libraries which dracut fails to auto-detect Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Bump yip to get this fix: mudler/yip#110 as part of this: kairos-io/kairos#1831 Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> * Fix lint errors Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> --------- Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me> (cherry picked from commit 6b07d39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: kairos-io/kairos#1831