Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part name construction for devices like mmcblk0p1 and nvme0n1p1 #110

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jimmykarily
Copy link
Collaborator

@jimmykarily jimmykarily commented Sep 18, 2023

@jimmykarily jimmykarily self-assigned this Sep 18, 2023
Part of: kairos-io/kairos#1831

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit to kairos-io/kairos-agent that referenced this pull request Sep 22, 2023
to get this fix: mudler/yip#110

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit to kairos-io/immucore that referenced this pull request Sep 22, 2023
to get this fix: mudler/yip#110

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Copy link
Collaborator

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimmykarily jimmykarily merged commit 33f3678 into master Sep 25, 2023
4 checks passed
@jimmykarily jimmykarily deleted the fix-part-name branch September 25, 2023 07:17
jimmykarily added a commit to kairos-io/kairos-agent that referenced this pull request Sep 25, 2023
to get this fix: mudler/yip#110

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit to kairos-io/immucore that referenced this pull request Sep 25, 2023
to get this fix: mudler/yip#110

as part of this: kairos-io/kairos#1831

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
jimmykarily added a commit to kairos-io/immucore that referenced this pull request Sep 25, 2023
* Add awk and gawk in the initrafms

to allow growpart to work. Also include libraries which dracut fails to
auto-detect

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Bump yip

to get this fix: mudler/yip#110

as part of this: kairos-io/kairos#1831

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Fix lint errors

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

---------

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Itxaka pushed a commit to kairos-io/immucore that referenced this pull request Sep 26, 2023
* Add awk and gawk in the initrafms

to allow growpart to work. Also include libraries which dracut fails to
auto-detect

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Bump yip

to get this fix: mudler/yip#110

as part of this: kairos-io/kairos#1831

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Fix lint errors

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

---------

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
(cherry picked from commit 6b07d39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants