Drop resolvconf import #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package moby is updated and now the resolvconf part points to internal packages which makes it un-importable to use directly As we only want to write a simple resolv.conf so we can just add a few lines of code to do so Signed-off-by: Itxaka <itxaka@kairos.io>
Itxaka
force-pushed
the
drop_resolvconf_dep
branch
from
b461da9
to
421fe21
Compare
mudler
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package moby is updated and now the resolvconf part points to internal packages which makes it un-importable to use directly
As we only want to write a simple resolv.conf so we can just add a few lines of code to do so
This also solves https://osv.dev/vulnerability/GO-2024-3005 by bumping github.com/moby/moby