Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Strings in TableStyle #17

Closed
Xitian9 opened this issue Sep 2, 2021 · 2 comments · Fixed by #21
Closed

Allow Strings in TableStyle #17

Xitian9 opened this issue Sep 2, 2021 · 2 comments · Fixed by #21

Comments

@Xitian9
Copy link
Collaborator

Xitian9 commented Sep 2, 2021

Currently TableStyle allows only a single character for the various separators. Occasionally you may want to allow more flexibility: for example, you may want a double-thick line in ASCII for vertical separators||, or you may wish to exclude the outer border of a table entirely.

Would you be open to a PR to enable this functionality?
@muesli4
Copy link
Owner

muesli4 commented Sep 2, 2021

Yes, your contribution would be very welcome. Although, when it comes to any design questions I would like to be involved. Let me know if there is anything you need.

@Xitian9 Xitian9 mentioned this issue Sep 4, 2021
Merged
@Xitian9
Copy link
Collaborator Author

Xitian9 commented Sep 6, 2021

I've submitted a couple of PRs addressing this and other issues. I don't mean this to be an end-run around design questions, but just so we have something concrete to look at when discussing any issues. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Strings for TableStyle delimiters. Xitian9/table-layout
2 participants
@muesli4 @Xitian9