-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Strings for TableStyle delimiters. #21
Conversation
f50d3cf
to
6246380
Compare
I think I've addressed all the comments. Let me know if you'd like other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it seems fine to me. After those small changes are done I will merge it.
And I wanted to take the chance to say thank you again for your work and your patience. I know how much it sucks having to wait for a review on open source projects. I promised myself to never do it this way but I guess I understand the reasons why this happens now. ;)
In TableStyle, split vertical separators into left, centre, and right variants. groupV -> groupL, groupC, and groupR headerV -> headerL, headerC, and headerR
Updated. Let me know if that's satisfactory. And don't worry about the wait; thank you for maintaining this wonderful library! |
Fixes #17.
This allows a greater range of delimiters allowed in tables, including multi-character delimiters like
||
, or null delimiters""
. This furthermore allows us to create tables with no outer borders.Here are two examples of new table styles created with this.
Using
asciiDoubleS
:Using
withoutBorders unicodeS
: