Allow inheritance #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmiclat
changed the title
|
Sorry for only replying after almost 2 years! I let the project slide for quite a while. Thanks for this great contribution anyways! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was facing some issues when trying to extend QuadKey via inheritance. Mainly when I inherited from
QuadKey, my methods were not accessible after using some methods like.difference()or.parent().After looking into it, I figured out that this is because these methods are hardcoded to return a
QuadKeyinstance instead of my own class. I fixed it by replacingQuadKeywithself.__class__()or turning the method into a class method and convertingQuadKeytocls(...). Let me know what you think and if you have any suggestions for improvements!