Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature java17 cdk #19

Merged
merged 12 commits into from
Dec 12, 2022
Merged

Feature java17 cdk #19

merged 12 commits into from
Dec 12, 2022

Conversation

muhamadto
Copy link
Owner

@muhamadto muhamadto commented Dec 7, 2022

Hello, Please Review My Pull Request!

  • Added CDK and github actions to deploy to AWS
  • Added CDK tests
  • Configured Sonarcloud
  • Added docker-compose file to run the service locally

More work required on:

  • onSuccess and onFailure SNS publishing
  • Enhance test coverage
  • Simulate AWS API gateway in docker-compose
  • Enhance documentation to include docker-compose building and running

I decided to break here and create a PR as it was becoming a massive PR. The rest are coming in subsequent change.

✔️ Checklist

  • Describe what you did in the pull request description
  • Add Unit and Integration Tests - at least 80% unit tests for new code.
  • Added or updated documentation

Signed-off-by: Matto <muhamadto@gmail.com>
Signed-off-by: Matto <muhamadto@gmail.com>
Signed-off-by: Matto <muhamadto@gmail.com>
…nctionInvoker::handleRequest`

Signed-off-by: Matto <muhamadto@gmail.com>
Signed-off-by: Matto <muhamadto@gmail.com>
Signed-off-by: Matto <muhamadto@gmail.com>
Signed-off-by: Matto <muhamadto@gmail.com>
@muhamadto muhamadto reopened this Dec 7, 2022
Signed-off-by: Muhammad Hamadto <muhamadto@gmail.com>
Signed-off-by: Matto <muhamadto@gmail.com>
@muhamadto muhamadto self-assigned this Dec 7, 2022
@muhamadto muhamadto marked this pull request as draft December 7, 2022 23:31
@muhamadto muhamadto force-pushed the feature-java17-cdk branch 5 times, most recently from 1364822 to 8b38425 Compare December 11, 2022 12:00
@muhamadto muhamadto marked this pull request as ready for review December 11, 2022 12:09
Signed-off-by: Matto <muhamadto@gmail.com>
Signed-off-by: Muhammad Hamadto <muhamadto@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

59.6% 59.6% Coverage
0.0% 0.0% Duplication

@muhamadto muhamadto merged commit 1d4982c into java17 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant