[core] Simplify build scripts #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
force-pushed
the
simplify-build
branch
from
fd048c6
to
d99720e
Compare
mnajdova
reviewed
Mar 1, 2024
|
Makes sense, should we wait for mui/material-ui#41102 to be merged first? |
|
We don't really have to - we're not going to release Base UI packages anytime soon. When mui/material-ui#41102 is merged, we'll have to adapt it anyway so that our "esm" bundle is truly ESM. |
mnajdova
approved these changes
Mar 15, 2024
michaldudak
force-pushed
the
simplify-build
branch
from
d99720e
to
45d1ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
legacyandmodernbuild targets. We'll ship standard ESM (once mui/material-ui#41102 is complete and ready to be ported to Base UI) and CommonJS for Node.Also removed the custom TS build script, as the issue it works around has been resolved.