Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooltip] Component and Hook #264

Merged
merged 64 commits into from
May 29, 2024
Merged

[Tooltip] Component and Hook #264

merged 64 commits into from
May 29, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Apr 3, 2024

Closes #32

Preview: https://deploy-preview-264--base-ui.netlify.app/base-ui/react-tooltip/
Transition experiment: https://deploy-preview-264--base-ui.netlify.app/experiments/tooltip/

TODO:

  • Tests - a lot of the implementation details are tested by Floating UI already, so we only need to test the wrapping APIs.
  • Complete documentation

@atomiks atomiks marked this pull request as draft April 3, 2024 08:13
@atomiks atomiks added the component: tooltip This is the name of the generic UI component, not the React module! label Apr 3, 2024
@colmtuite
Copy link
Contributor

colmtuite commented Apr 3, 2024

@atomiks Hilarious to see this in one day 🤣🔥

  1. Tooltip should close then you click whatever is inside Anchor.
  2. We should specify a default delay, something around 750ms.
  3. I'm not a fan of the object syntax for setting open and close inside the same delay prop. One reason is that it's not intuitive that setting delay also sets the close delay. Another is just the awkward ergonomics. I'd rather two separate props. However, it's also worth considering not supporting a close delay at all. Can you think of a reason why one is necessary?
  4. When a tooltip is open, and I very quickly hover another element with a tooltip, the next tooltip should open instantly with no delay, regardless of its delay setting. There should be ms threshold for how much time must pass after the first tooltip closes, before you open the second tooltip, for its delay to be removed. Radix calls this skipDelayDuration and it's configurable. RA calls it "cooldown period" and it looks like it's not configurable. I'm guessing since we're not using a Tooltip Provider, and each tooltip is responsible only for its own settings, we can't configure this globally across all tooltips? If that's the case, then I think it's probably ok that it's not configurable.
  5. Do we need a global Tooltip Provider? Related to the above point.
  6. anchorGap is confusing to me, since when I read it, I'm not 100% sure what "anchor" or "gap" means. I think "offset" is a more appropriate name.
  7. I think anchorGap | offset should be on Content rather than Root.
  8. What is the benefit of the allowTouch prop? Is there an issue with just having tooltips not work on touch devices?

@atomiks
Copy link
Contributor Author

atomiks commented Apr 3, 2024

@colmtuite

  1. Good point, will add.
  2. I'm wondering if we should use the "mouse rest" behavior instead of a delay by default? Ideally, you only want to show the tooltip when the cursor is at rest, rather than an arbitrary delay (Floating UI supports both though).
  3. Fair enough. I'm not sure, the delay being symmetric by default and is how I've always done it and there hasn't really been any complaints, but I can see why you might want it to only affect the open delay, or have separate props.
  4. This is implemented as TooltipDelayGroup in the PR currently. It can be global, or wrap only a specific group, allowing you to change the delay granularly.
  5. ^
  6. I personally like that it matches the gap prop in flexbox. But yeah, it's called offset in Floating UI - the problem is there are two different types of offsets (side and alignment axis).
  7. That does make more sense
  8. Devs may hide somewhat critical info behind tooltips in some cases, so it should be shown on touch by default imo (at least to get a consistent experience across all devices by default).

Hilarious to see this in one day 🤣🔥

Yeah 😄 as the review comment above says, it's really 2 years of work, compressed into 1 day since I can just reuse all that work I did.

@colmtuite
Copy link
Contributor

  1. Is this a component? Does it exist outside of Tooltip? If it's a component, it's missing from the docs Anatomy section.
  2. sideOffset and alignmentOffset seems like the way forward here? Radix does similar.
  3. How does this work? Like what's the interaction? Touch devices don't support hover (which is how a tooltip is triggered), so I don't see how it would work?

@atomiks
Copy link
Contributor Author

atomiks commented Apr 3, 2024

  1. Yes it's a separate component, not documented currently. It's not really part of the default anatomy since it's a separate feature that wraps it. (Edit: it's now documented.)
  2. I like those! I guess separating side and alignment into separate props instead of Floating UI's placement may work better if we do that? Or is a single placement prop still more ergonomic?

  1. They tap it and it shows the tooltip; if they tap off it closes.

The main use case where this is necessary for touch input is the "infotip" pattern, where an info icon can be tapped to reveal information. It's not a button tool that performs an action, as the action itself is to show the infotip. For keyboard usage, this pattern may require a click handler rather than focus, if it's attached to a button. Not 100% sure about the screen reader/keyboard a11y of this.

Another potential solution is to use long press to show the tooltip on touch devices, rather than a tap. This lets them see the description without triggering the button. Probably somewhat rare?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 3, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 4, 2024
@atomiks atomiks force-pushed the feat/Tooltip branch 4 times, most recently from 8d4d38b to 1efbbb8 Compare April 8, 2024 00:40
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 8, 2024
@atomiks atomiks force-pushed the feat/Tooltip branch 3 times, most recently from 22e2843 to 11f1654 Compare April 11, 2024 06:56
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 11, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 12, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 16, 2024
@atomiks atomiks force-pushed the feat/Tooltip branch 2 times, most recently from 4966245 to b3f0b25 Compare April 17, 2024 05:17
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 22, 2024
@atomiks
Copy link
Contributor Author

atomiks commented May 27, 2024

Group/Provider should be in Anatomy. imo it should communicated as the default way of using Tooltip for almost all users.

It's a bit confusing in Anatomy since Root is the one that says "wraps all other components" but now you have this extra one. Given it's optional too, I've added it directly beneath Anatomy to explain it a bit better.

imo the default delay is waaaaayyy too short. I recommend 750ms as the default.
imo delayType default should be hover? I think it's the most common expectation, and would also match the the title attr bevaiour.

The thing with the rest type is that it can be shorter than you need with hover. With hover, the timeout starts as soon as you enter the element, even if your cursor is gliding across it unintentionally, so it needs to be longer. With rest, the user has stopped and is showing intentionality to use the tool, waiting for any extra info (the tooltip) to appear to help them. I found 200ms is about the ideal length to show the tooltip as quickly as possible without it appearing under normal clicking circumstances (i.e. the user already knows the tool by heart and doesn't want to see the tooltip appear anymore). I can make it a bit longer, but the point is it doesn't actually need to be so long with this technique. Update: increased to 300ms

@@ -4,7 +4,7 @@ const fse = require('fs-extra');
const errorCodesPath = path.resolve(__dirname, './public/static/error-codes.json');

const { version: transformRuntimeVersion } = fse.readJSONSync(
require.resolve('@babel/runtime-corejs2/package.json'),
require.resolve('@babel/runtime-corejs3/package.json'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already on master, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I added it here to validate it first and because the docs/demos were broken without it before the other PR got merged

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@atomiks atomiks merged commit ace9e17 into mui:master May 29, 2024
18 checks passed
@atomiks atomiks deleted the feat/Tooltip branch May 29, 2024 11:48
@mikkelblanne
Copy link

@atomiks Great to see this done - minor detail: In the initial description, "Closes" is currently referencing mui/material-ui instead of mui/base-ui #32 :)

@michaldudak
Copy link
Member

Good catch, thanks!

@Floriferous
Copy link

The docs say Tooltip is still "Planned". Can we use this or not?

@atomiks
Copy link
Contributor Author

atomiks commented Jul 8, 2024

Hi @Floriferous, the docs that are live refer to an older version of Base UI that is no longer being developed. We are actively working on the new version of Base UI that will be released properly in the upcoming months, which has this component included. You can keep an eye out for the launch on the X account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tooltip] Implement Tooltip
7 participants