-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popover] Component and Hook #381
Conversation
Netlify deploy preview |
3b4e961
to
6606738
Compare
|
Popovers are non-modal elements that don't trap focus by default. They don't have a backdrop and don't make things inert behind them. They do manoeuvre focus to the correct tabbable elements in the DOM tree however when tabbing or moving through elements with the virtual cursor.
This one is pretty subjective and I think we should match whatever
Unlike tooltips whose trigger performs an action unrelated to the tooltip, the delay seems like it should be be much shorter to show the popover quickly on hover, as its trigger's only purpose is to open the popover itself? |
packages/mui-base/src/useTransitionStatus/useTransitionStatus.ts
Outdated
Show resolved
Hide resolved
packages/mui-base/src/useTransitionStatus/useTransitionStatus.types.ts
Outdated
Show resolved
Hide resolved
packages/mui-base/src/Popover/Positioner/usePopoverPositioner.tsx
Outdated
Show resolved
Hide resolved
@atomiks Decisions made after a chat:
|
3ae39a8
to
46026c0
Compare
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: atomiks <cc.glows@gmail.com>
Preview: https://deploy-preview-381--base-ui.netlify.app/base-ui/react-popover/
Closes #35