Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Encapsulate the common rendering logic in useComponentRenderer #408

Merged
merged 2 commits into from
May 22, 2024
Merged

[core] Encapsulate the common rendering logic in useComponentRenderer #408

merged 2 commits into from
May 22, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented May 22, 2024 •
edited
Loading

Move the rendering logic to the new useComponentRenderer hook:

  • resolving class name
  • transforming ownerState into style hooks
  • resolving the render prop
  • merging refs

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label May 22, 2024
@michaldudak michaldudak requested a review from atomiks May 22, 2024 09:05
@mui-bot
Copy link

mui-bot commented May 22, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-408--base-ui.netlify.app/

Generated by 🚫 dangerJS against 4397adb

@michaldudak michaldudak marked this pull request as ready for review May 22, 2024 13:36
@michaldudak michaldudak merged commit 21440d2 into mui:master May 22, 2024
18 checks passed
@michaldudak michaldudak deleted the useComponentRenderer branch May 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @atomiks