[core] Move legacy components to a subdirectory #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
michaldudak
force-pushed
the
move-legacy-components
branch
from
887f180
to
bf1a4ae
Compare
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
colmtuite
approved these changes
Jun 4, 2024
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
|
Changes look good - you could move the old Slider files as well, I don't mind rebasing and I've already kinda moved them in my PR already! |
atomiks
approved these changes
Jun 11, 2024
|
@mj12albert, I left the Slider as it was, to make it easier to keep the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the @mui/base components to the legacy subdirectory and excluded them from being packaged.
I left the hooks we use in the new components (useButton, useList, etc.) and the Slider, to avoid conflicts with #373.
I ran into the problem with failing tests after clicking on a label in another test. This seems like a bug in one of the tools we use. I decided to skip these two failing tests for now.