Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Refactor animation hooks #417

Merged
merged 4 commits into from
May 28, 2024
Merged

[core] Refactor animation hooks #417

merged 4 commits into from
May 28, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented May 27, 2024

  • I have followed (at least) the PR section of the contributing guide.

  • Refactors useExecuteIfNotAnimated to useAnimationsFinished using node.getAnimations() instead of reading CSS styles.

  • Adds enabled boolean to useTransitionStatus that prevents the logic from running and performing new re-renders (for animated={false} prop).

@atomiks atomiks added the core Infrastructure work going on behind the scenes label May 27, 2024
@mui-bot
Copy link

mui-bot commented May 27, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-417--base-ui.netlify.app/

Generated by 🚫 dangerJS against 6b45ff0

@atomiks atomiks merged commit 3176539 into mui:master May 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomiks @mui-bot @michaldudak