[core] Verify types in test code #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy preview |
Janpot
reviewed
Jun 19, 2024
colmtuite
approved these changes
Jun 19, 2024
michaldudak
force-pushed
the
typecheck-tests
branch
from
a73bcf2
to
8907ed3
Compare
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Janpot
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
👍 Let's move forward with this.
Just for tracking purposes: Building multiple projects with references could lead to weird race conditions as we saw in mui/material-ui#30200. Something we could avoid by building type declarations in a single tsc command at the monorepo level, again with project references to every project that needs its types emitted. Something to experiment with in follow-up
atomiks
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current setup omits test code while typechecking on the root level (
pnpm typescriptrun in workspace root). This PR fixes it by defining tests as a separate TS project and referencing production code in their tsconfig, as discussed with @Janpot on the code infra meeting.