Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Wait for focus to settle in tests #491

Merged
merged 1 commit into from
Jul 25, 2024
Merged

[Popover] Wait for focus to settle in tests #491

merged 1 commit into from
Jul 25, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jul 25, 2024 •
edited
Loading

Add waitFor around focus check to give the browser more time to set focus.

@michaldudak michaldudak added test component: popover The React component. labels Jul 25, 2024
@mui-bot
Copy link

mui-bot commented Jul 25, 2024

Netlify deploy preview

https://deploy-preview-491--base-ui.netlify.app/

Generated by 🚫 dangerJS against cad5fcf

@michaldudak michaldudak marked this pull request as ready for review July 25, 2024 11:06
@michaldudak michaldudak merged commit 1eb94a7 into mui:master Jul 25, 2024
19 of 20 checks passed
@michaldudak michaldudak deleted the fix-popover-test branch July 25, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
component: popover The React component. test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @atomiks