Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting "disabled" on DatePicker doesn't prevent the dialog from opening on click in beta #1033

Closed
alexplumb opened this issue May 7, 2019 · 1 comment
Closed

Setting "disabled" on DatePicker doesn't prevent the dialog from opening on click in beta #1033

alexplumb opened this issue May 7, 2019 · 1 comment

Comments

@alexplumb
Copy link

Environment

Tech Version
@material-ui/pickers 3.0.0-beta1
material-ui 4.0.0-beta1
React 16.8.6
Browser Chrome
Peer library luxon

Steps to reproduce

  1. Set a DatePicker or DateTimePicker to "disabled" - this should set the underlying TextField to be disabled
  2. Click on the disabled TextField

Expected behavior

Nothing should happen

Actual behavior

The date picker dialog opens up and allows me to change the date.

Live example

I've attached identical code for both v2 and v3. Clicking the date picker is unresponsive as expected in v2 but displays the dialog in v3.

v2: https://codesandbox.io/embed/kw1397yor5
v3: https://codesandbox.io/embed/1vop3zr97
dmtrKovalenko added a commit that referenced this issue May 8, 2019
@dmtrKovalenko
[#1033] Properly handle disabled prop
dfa6041
@dmtrKovalenko
Copy link
Member

Fixed in rc.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexplumb @dmtrKovalenko