Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#925] [#930] Support views and openTo props for InlineDatePicker #933

Merged
merged 2 commits into from
Mar 1, 2019

Conversation

dmtrKovalenko
Copy link
Member

This PR closes #925 #929 #930

Description

Views and openTo props fixes

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #933 into develop will decrease coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #933      +/-   ##
===========================================
- Coverage    92.52%   92.46%   -0.07%     
===========================================
  Files           48       48              
  Lines         1378     1380       +2     
  Branches       124      124              
===========================================
+ Hits          1275     1276       +1     
  Misses          74       74              
- Partials        29       30       +1
Impacted Files Coverage Δ
lib/src/DatePicker/DatePickerInline.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/DatePicker.tsx 96.92% <66.66%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcaeaa...aafef12. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #933 into develop will decrease coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #933      +/-   ##
===========================================
- Coverage    92.52%   92.46%   -0.07%     
===========================================
  Files           48       48              
  Lines         1378     1380       +2     
  Branches       124      124              
===========================================
+ Hits          1275     1276       +1     
  Misses          74       74              
- Partials        29       30       +1
Impacted Files Coverage Δ
lib/src/DatePicker/DatePickerInline.tsx 100% <100%> (ø) ⬆️
lib/src/DatePicker/DatePicker.tsx 96.92% <66.66%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcaeaa...aafef12. Read the comment docs.

@dmtrKovalenko dmtrKovalenko merged commit f36f617 into develop Mar 1, 2019
@dmtrKovalenko dmtrKovalenko deleted the bugfix/views-for-inline branch March 5, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant