[internal] Fix naming to match convention

Author: oliviertassinari

packages/api-docs-builder/ApiBuilders/ComponentApiBuilder.ts

@@ -701,10 +701,10 @@ const attachTable = (
       };
     })
     .reduce((acc, cssVarDefinition) => {
-      const { name, ...rest } = cssVarDefinition;
+      const { name, ...other } = cssVarDefinition;
       return {
         ...acc,
-        [name]: rest,
+        [name]: other,
       };
     }, {});
 

packages/mui-material-nextjs/src/v13-pagesRouter/createCache.ts

@@ -17,9 +17,9 @@ export default function createEmotionCache(
     insertionPoint = emotionInsertionPoint ?? undefined;
   }
 
-  const { enableCssLayer, ...rest } = options ?? {};
+  const { enableCssLayer, ...other } = options ?? {};
 
-  const emotionCache = createCache({ key: 'mui', insertionPoint, ...rest });
+  const emotionCache = createCache({ key: 'mui', insertionPoint, ...other });
   if (enableCssLayer) {
     const prevInsert = emotionCache.insert;
     emotionCache.insert = (...args) => {

packages/mui-material/src/TextField/TextField.test.js

@@ -22,9 +22,9 @@ describe('<TextField />', () => {
   }
 
   function TestFormControl(props) {
-    const { children, error, ...rest } = props;
+    const { children, error, ...other } = props;
     return (
-      <FormControl data-testid={'custom'} {...rest}>
+      <FormControl data-testid={'custom'} {...other}>
         {children}
       </FormControl>
     );

packages/mui-material/src/styles/createColorScheme.ts

@@ -28,14 +28,14 @@ export default function createColorScheme(options: ColorSystemOptions & { colorS
     opacity,
     overlays,
     colorSpace,
-    ...rest
+    ...other
   } = options;
   // need to cast because `colorSpace` is considered internal at the moment.
   const palette = createPalette({ ...paletteInput, colorSpace } as PaletteOptions);
   return {
     palette,
     opacity: { ...getOpacity(palette.mode), ...opacity },
     overlays: overlays || getOverlays(palette.mode),
-    ...rest,
+    ...other,
   } as unknown as ColorSystemOptions;
 }

packages/mui-material/src/styles/createTheme.ts

@@ -56,7 +56,7 @@ export default function createTheme(
     cssVariables = false,
     colorSchemes: initialColorSchemes = !palette ? { light: true } : undefined,
     defaultColorScheme: initialDefaultColorScheme = palette?.mode,
-    ...rest
+    ...other
   } = options;
   const defaultColorSchemeInput = (initialDefaultColorScheme as DefaultColorScheme) || 'light';
   const defaultScheme = initialColorSchemes?.[defaultColorSchemeInput];
@@ -125,7 +125,7 @@ export default function createTheme(
 
   return createThemeWithVars(
     {
-      ...rest,
+      ...other,
       colorSchemes: colorSchemesInput,
       defaultColorScheme: defaultColorSchemeInput,
       ...(typeof cssVariables !== 'boolean' && cssVariables),

scripts/copyFilesUtils.mjs

@@ -103,7 +103,7 @@ const srcCondition = 'mui-src';
 
 function createExportFor(exportName, conditions) {
   if (typeof conditions === 'object' && conditions) {
-    const { [srcCondition]: src, ...rest } = conditions;
+    const { [srcCondition]: src, ...other } = conditions;
     if (typeof src === 'string') {
       if (!/\.tsx?$/.test(src)) {
         throw new Error(`Invalid src condition for ${exportName}: ${src}`);
@@ -119,7 +119,7 @@ function createExportFor(exportName, conditions) {
             types: `./esm/${baseName}.d.ts`,
             default: `./esm/${baseName}.js`,
           },
-          ...rest,
+          ...other,
         },
       };
     }