Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Add missing autoFocus TypeScript types #16289

Merged
merged 3 commits into from
Jun 19, 2019
Merged

[Menu] Add missing autoFocus TypeScript types #16289

merged 3 commits into from
Jun 19, 2019

Conversation

BassT
Copy link
Contributor

@BassT BassT commented Jun 19, 2019 •
edited by eps1lon
Loading

Edit @eps1lon:
Closes #16189

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 19, 2019 •
edited
Loading

No bundle size changes comparing 3de4acf...5259138

Generated by 🚫 dangerJS against 5259138

@oliviertassinari
Copy link
Member

Seems related to #16189 and #16245.

@eps1lon eps1lon self-assigned this Jun 19, 2019
@eps1lon
Copy link
Member

eps1lon commented Jun 19, 2019

#16245 Is a bit more complicated. I improved additional types to add types for everything introduced in #15360.

@eps1lon eps1lon changed the title [Menu] Add missing autoFocus property to MenuProps [Menu] Add missing autoFocus TypeScript types Jun 19, 2019
@eps1lon eps1lon added the package: material-ui Specific to @mui/material label Jun 19, 2019
@eps1lon eps1lon merged commit 5ce2141 into mui:master Jun 19, 2019
@eps1lon
Copy link
Member

eps1lon commented Jun 19, 2019

@BassT Much appreciated. Thanks!

@BassT BassT deleted the patch-1 branch June 19, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eps1lon eps1lon

Labels
package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autoFocus is a unknown ListItem property in TypeScript since 4.0
4 participants
@BassT @mui-pr-bot @oliviertassinari @eps1lon