[StepButton] Don't flow into StepContent when vertical #16414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
Details of bundle changes.Comparing: ffb125d...80e1413
|
| @@ -41,7 +41,7 @@ const Step = React.forwardRef(function Step(props, ref) { | |||
| disabled = false, | |||
| index, | |||
| last, | |||
| orientation, | |||
| orientation = 'horizontal', | |||
There was a problem hiding this comment.
Do we need the default value? Can we expect it to be always provided by the parent Stepper component? (it's the same question for Step Button)
There was a problem hiding this comment.
I'm in favor of not having this default value so that it doesn't hide a potential issue with the parent component.
eps1lon
force-pushed
the
fix/stepper-vertical-button
branch
from
393baea
to
80e1413
Compare
|
I have added the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11857
Demo is low-effort content for a friday. Just had to change spacing for vertical buttons.