Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuItem] Fix dense prop support #16510

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Conversation

sumedhan
Copy link
Contributor

@sumedhan sumedhan commented Jul 8, 2019

Closes #16488

Thanks!

@mui-pr-bot
Copy link

mui-pr-bot commented Jul 8, 2019

Details of bundle changes.

Comparing: 7d826a9...060a8a7

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 +0.02% 🔺 327,349 327,398 90,365 90,383
@material-ui/core/Paper 0.00% 0.00% 68,290 68,290 20,375 20,375
@material-ui/core/Paper.esm 0.00% 0.00% 61,574 61,574 19,155 19,155
@material-ui/core/Popper 0.00% 0.00% 28,942 28,942 10,408 10,408
@material-ui/core/Textarea 0.00% 0.00% 5,505 5,505 2,365 2,365
@material-ui/core/TrapFocus 0.00% 0.00% 3,753 3,753 1,576 1,576
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,012 16,012 5,793 5,793
@material-ui/core/useMediaQuery 0.00% 0.00% 2,595 2,595 1,103 1,103
@material-ui/lab 0.00% 0.00% 137,896 137,896 42,523 42,523
@material-ui/styles 0.00% 0.00% 51,699 51,699 15,348 15,348
@material-ui/system 0.00% 0.00% 15,428 15,428 4,395 4,395
Button 0.00% 0.00% 84,442 84,442 25,738 25,738
Modal 0.00% 0.00% 14,515 14,515 5,088 5,088
Portal 0.00% 0.00% 3,471 3,471 1,573 1,573
Slider 0.00% 0.00% 74,976 74,976 23,292 23,292
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 54,338 54,338 13,762 13,762
docs.main +0.01% 🔺 +0.01% 🔺 647,009 647,058 203,904 203,931
packages/material-ui/build/umd/material-ui.production.min.js +0.02% 🔺 +0.02% 🔺 299,721 299,770 85,971 85,987

Generated by 🚫 dangerJS against 060a8a7

@oliviertassinari oliviertassinari changed the title [MenuItem] Fix dense property in MenuItem component [MenuItem] Fix dense prop support Jul 8, 2019
@oliviertassinari oliviertassinari added the component: menu This is the name of the generic UI component, not the React module! label Jul 8, 2019
@eps1lon eps1lon merged commit 1388c2a into mui:master Jul 9, 2019
@eps1lon
Copy link
Member

eps1lon commented Jul 9, 2019

@sumedhan It's a great first pull request on Material-UI. Thank you for working on it!

@sumedhan
Copy link
Contributor Author

sumedhan commented Jul 9, 2019

Thanks @eps1lon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MenuItem] dense not working
4 participants