-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Improve UX for pointing device with limited accuracy #18174
[Slider] Improve UX for pointing device with limited accuracy #18174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an alternative solution to #18074. It aims to find a tradeoff between:
It is not an alternative as was extensively described in the original PR. Could you make an argument for each of these statements?
I don't understand your point. From what I understand #18174 and #18074 try to solve the same problem: from time to time when we try to interact with the slider on mobile, we have to give multiple tries, until our finger actually touches the rail DOM node.
Do you mean, why are these dimensions important? |
Details of bundle changes.Comparing: 3e25d1b...e33b92e
|
How are these addressed or apply here.
I even made a video. I can't help you more without physically pointing the pointer for you. Nothing in my PR talks about mobile. |
@eps1lon Oh, I think that I understand your point now, I was confused by the 48px touch target, for touch devices and the recording on a pointer device (the 7mm - 9mm recommendation of Google Material Design only applies to touch devices, right?) and the mention to a regression with v3. So these two pull requests solve two different problems. #18074 is about increasing the thumb interaction zone from this zone on desktop: Thanks for the patience, it took me some time to understand. |
Yes I shouldn't have used this term. I just wanted to explain where the size comes from which lead to the misunderstanding that this targets mobile devices. |
@eps1lon Ok awesome, sounds like a great change 👍. |
The problem: from time to time when we try to interact with the slider on mobile, we have to give multiple tries, until our finger actually touches the rail DOM node.
The changes aim to find a tradeoff between: