Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #21928

Merged
merged 13 commits into from
Jul 27, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 25, 2020

This time, I had to split the work into 2 other PRs:

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Jul 25, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 25, 2020

Details of bundle changes

Generated by 🚫 dangerJS against 30b8145

oliviertassinari and others added 2 commits July 25, 2020 18:36
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-authored-by: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 26, 2020
docs/src/pages/discover-more/roadmap/roadmap.md Outdated Show resolved Hide resolved
- ⏳ Planning to build
- ⭐️ We will consider making some of the features paid (non MIT)
- ⭐️ We will make some of the features available in [Material-UI X](https://github.com/mui-org/material-ui-x) (non-MIT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbols says "new" to me.

Suggested change
- ⭐️ We will make some of the features available in [Material-UI X](https://github.com/mui-org/material-ui-x) (non-MIT)
- 💵 We will make some of the features available in [Material-UI X](https://github.com/mui-org/material-ui-x) (non-MIT)

Or:
🔐 💳 💎 📦 ?

Copy link
Member Author

@oliviertassinari oliviertassinari Jul 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or ✨(airtable), or ⚡ (can't recall in which product I have seen this one). I think that it should communicate the "advanced" as well as it's "different" meaning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ - sparkly and new?
⚡ - possibly, although does it suggest "paid" to you?
💎 - says "premium", and is associated with value. Could be an option, although not to be confused with Diamond Sponsors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for ⚡, but not strong preference. I think that we could ask the designers to come with something to differentiate the different pages in the left side navigation as well on the overall layout.

docs/src/pages/discover-more/roadmap/roadmap.md Outdated Show resolved Hide resolved
Co-authored-by: Matt <github@nospam.33m.co>
@oliviertassinari oliviertassinari removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 26, 2020
@oliviertassinari oliviertassinari merged commit f716030 into mui:next Jul 27, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v25 branch July 27, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants