[IconMenu] Add open, onRequestChange properties, fix #2341

[quangbuule]

Hi,
This is an update of #2343
I rebased the branch to the latest upstream code.

[alitaheri]

I'm ok with this, but do you think 'esc' should be 'escape' to keep consistent with LeftNav? or should I rename the LeftNav one? Which one makes more sense? @oliviertassinari @quangbuule

[quangbuule]

I think 'escape' have more sense. Personally, I like the way that just send the event to user for him to decide.

[oliviertassinari]

escape 👍

[oliviertassinari]

It's null now.

[quangbuule]

I updated to escape reason already. @oliviertassinari @subjectix

[alitaheri]

👍 Do a rebase and make this a single commit, then we are good to merge. right? @oliviertassinari

[quangbuule]

I rebased at begining of the PR @oliviertassinari

[alitaheri]

@quangbuule I think you are missing a force push:

git push origin icon-menu --force

That will forcefully update your remote branch and clear the history. It will the look exactly like how you see it after you rebase locally

[quangbuule]

I did rebase -i instead of rebase. @subjectix @oliviertassinari take a look 😄

[oliviertassinari]

@quangbuule Perfect 👍

[alitaheri]

Nice work 👍 👍 Thanks 😁