Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Run in StrictMode by default #27693

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 11, 2021

Just like tests are run with StrictMode by default, docs now also use StrictMode by default.

This will help us detect incompatibilities with React 18 sooner.

Went through every page (except every API page) and only found issues with pages using react-swipeable-views (componentWillReceiveProps). We'll probably drop usage of that package once React 18 lands.

Preview: https://deploy-preview-27693--material-ui.netlify.app/

The final step for #13394

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Aug 11, 2021
@eps1lon eps1lon added this to the React 18 milestone Aug 11, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 11, 2021

Details of bundle changes (experimental)

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against d2a2eae

@eps1lon eps1lon marked this pull request as ready for review August 11, 2021 14:43
@eps1lon eps1lon merged commit 666e47d into mui:next Aug 17, 2021
@eps1lon eps1lon deleted the docs/strict-mode branch August 17, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants