[styled-engine] Add support for goober #27776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2021
oliviertassinari
force-pushed
the
styled-engine-goober
branch
from
d0a0bec
to
6f4b8a4
Compare
|
Bundle size will be reported once Azure build #31807 finishes. |
oliviertassinari
force-pushed
the
styled-engine-goober
branch
3 times, most recently
from
64893f6
to
c6f812f
Compare
oliviertassinari
force-pushed
the
styled-engine-goober
branch
from
c6f812f
to
be825e1
Compare
|
It seems that making it work would require a non-negligible amount of effort, there are a few bugs that are time-consuming to get to the bottom of. I'm not too far but I'm closing, for now, we could revisit in the future. It seems to have potential :D
The value could be for third-party libraries that want to minimize the style overhead, e.g. cristianbote/goober#180 (comment) by @iamhosseindhv. We might also want to see if developers do the effort to switch from emotion to styled-components. Two graphs to keep an eye on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have pushed the exploration further than I could in the past.
The incentive is https://bundlephobia.com/package/goober, likely 3 kB gzipped end-to-end, instead of +10 kB with emotion. You can see it used on https://react-hot-toast.com/.
<Alert>rendering<Typography>rendering<GlobalStyles>rendering<AppBar>rendering