-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug when extending styles #218
Labels
bug
Something isn't working
Comments
atersolis
added a commit
to atersolis/goober
that referenced
this issue
Jan 2, 2021
Hey @atersolis! Happy New Year! 🎉 Thank you for opening this issue and an already working PR! Amazing! 🙏 The issue is really odd 🤦 was actually convinced that this got fixed a while ago. Gonna dig a bit to look into it more. |
Hey @cristianbote I am having the same issue, is there any fix on this behaviour possible? |
9 tasks
Thanks for working on this one! Having the same issue and this would be 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thanks for this lib, I'm amazed by how much it can do while being less than 1kb.
I have reduced my bundle size by a lot using this with preact.
Unfortunately I have run into a bug while extending styles.
Here is a minimal code sample to reproduce the bug:
In this situation the text in UnderlinedBlue should be blue, but it's red
because of a wrong order of the class names in the class attribute. In that case, the classname ofRedBase
is after the classname ofBlue
and overwrite it.Sorry the class names are actually in the right order. The problem most likely comes from the order in which the classes are declared in the generated CSS.
However if I remove
<Orange>Orange</Orange>
, it is blue as expected.I am using goober 2.0.19-next.1
I will try to find some time to fix it.
happy new year !
The text was updated successfully, but these errors were encountered: