Fix forwardProps type

[oliviertassinari]

The type doesn't seem correct, the docs: https://goober.js.org/api/setup. Noticed, while I was working on mui/material-ui#27776.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cristianbote/goober-rocks/ELT9yrXTpgRQSSk8GaMt5giLaGEP
✅ Preview: https://goober-rocks-git-fork-oliviertassinari-patch-1-cristianbote.vercel.app

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit afe29b9:

Sandbox	Source
Vanilla	Configuration

[cristianbote]

Oh @oliviertassinari that's a good catch! Thank you!

Also nice exploration! 😄 Love the chance you have given to goober. If there's any more feedback you would need to complete it or issues to resolve let me know and I'll make sure to get some time on it.

Have a great one!

[oliviertassinari]

If there's any more feedback you would need to complete it or issues to resolve let me know and I'll make sure to get some time on it.

@cristianbote I have noticed a couple of inconsistencies. The high-level bit of what I could see:

• This TypeScript error. I had to @ts-ignore, fixed now.
• styled(a, b) is not supported as in emotion or sc. I had to do styled([a, b]).
• There are sometimes CSS injection order priority issue when doing styled(styled(div)). I couldn't fix it.
• We need to (I assume I didn't dive too deep on this one) customize the shouldForwardProp at the instance level, not the global level. I couldn't fix it.
• In createGlobalStyles, when returning [a, b], if both a and b have a body property, only the property in b win. It's not how emotion and styled-components behave. I had to use a small deepmerge util.
• emotion and sc have a auto unitless px addition logic. I had to add @emotion/unitless.
• I couldn't use withComponent. I had to remove support in MUI.
• There is an issue around how props are forwarded, I didn't have the time to get to the bottom of it, I could see 3-4 different symptoms around it.
• Likely more I didn't have the time to discover.

It feels like it could work, we aren't too far. I will try to link the potential in the v5 release blog post. Try to recruit members of the community to work on this. Preact support was easier :p. Each issue is a pain to debug 😁