Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] jss-to-tss migration advise to drop clsx in favor of cx #30527

Merged
merged 7 commits into from
Jan 13, 2022
Merged

[docs] jss-to-tss migration advise to drop clsx in favor of cx #30527

merged 7 commits into from
Jan 13, 2022

Conversation

garronej
Copy link
Contributor

@garronej garronej commented Jan 7, 2022 •
edited by oliviertassinari
Loading

Hi everyone,

Another addition to the jss-to-tss migration guide.
I realised that most people migrating from v4 do not realise that clsx !== cx so I mention it.

Best regards,

https://deploy-preview-30527--material-ui.netlify.app/guides/migration-v4/#2-use-tss-react

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 7, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 265c408

@garronej
[docs] Add notice about possible eslint errors using useMergedClasses…
265c408 
… (and workarounds)

Signed-off-by: garronej <joseph.garrone.gj@gmail.com>
@mui-bot
Copy link

mui-bot commented Jan 12, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 8307fe7

mnajdova
mnajdova approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@mnajdova mnajdova merged commit 38c1886 into mui:master Jan 13, 2022
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 15, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 15, 2022 •
edited
Loading

In https://deploy-preview-30527--material-ui.netlify.app/guides/migration-v4/#2-use-tss-react, it does the opposite:

Screenshot 2022-01-15 at 16 23 13

It's confusing, I think that we should fix the diff.

@garronej garronej mentioned this pull request Jan 22, 2022
Merged
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@garronej @wladimirguerra
[docs] jss-to-tss migration advise to drop clsx in favor of cx (mui#3…
5c91754 
…0527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@mbrookes mbrookes mbrookes approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@garronej @mui-pr-bot @mui-bot @oliviertassinari @mbrookes @mnajdova