[docs] jss-to-tss migration advise to drop clsx in favor of cx #30527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (and workarounds) Signed-off-by: garronej <joseph.garrone.gj@gmail.com>
mnajdova
reviewed
Jan 12, 2022
mnajdova
reviewed
Jan 12, 2022
mbrookes
approved these changes
Jan 12, 2022
mnajdova
reviewed
Jan 13, 2022
|
In https://deploy-preview-30527--material-ui.netlify.app/guides/migration-v4/#2-use-tss-react, it does the opposite:
It's confusing, I think that we should fix the diff. |
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
Another addition to the
jss-to-tssmigration guide.I realised that most people migrating from v4 do not realise that
clsx !== cxso I mention it.Best regards,
https://deploy-preview-30527--material-ui.netlify.app/guides/migration-v4/#2-use-tss-react