[core] Fix propTypes in components where OverridableStringUnion is used #30682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the framer:build is outputting some bogus code, no idea how to fix |
paales
added a commit
to graphcommerce-org/graphcommerce
that referenced
this pull request
Jan 20, 2022
mnajdova
approved these changes
Jan 26, 2022
I am afraid we need to remove these props. You can search for |
mnajdova
reviewed
Jan 31, 2022
| @@ -171,7 +171,10 @@ Button.propTypes /* remove-proptypes */ = { | |||
| * The color of the component. It supports those theme colors that make sense for this component. | |||
| * @default 'primary' | |||
| */ | |||
| color: PropTypes.oneOf(['context', 'danger', 'info', 'neutral', 'primary', 'success', 'warning']), | |||
| color: PropTypes /* @typescript-to-proptypes-ignore */.oneOfType([ | |||
mnajdova
changed the title
1 task
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @mnajdova I've created a PR to add missing string annotations for props that use the
OverridableStringUnionFixes #30715