-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Make @emotion/* fully supported in the System #33205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
Jun 22, 2022
mnajdova
added
bug 🐛
Something doesn't work
core
Infrastructure work going on behind the scenes
labels
Jul 5, 2022
mnajdova
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can go ahead and update the components with this change.
Ok great @mnajdova, |
Hi @mnajdova, |
mnajdova
requested changes
Jul 14, 2022
mnajdova
reviewed
Jul 27, 2022
mnajdova
reviewed
Jul 27, 2022
mnajdova
approved these changes
Jul 27, 2022
🥳 |
This was referenced Aug 8, 2022
Closed
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Co-authored-by: Michał Dudak <michal@dudak.me>
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is a follow-up on #32067 and is addressing #31825.
It is a POC with only the
Button
component.The visual test case can be run with:
Then accessing: http://localhost:3000/regression-Button/EmotionCompat#no-dev
With this branch you'll get:
With
mui/material-ui#master
:Summary, for the record, of why I am doing this:
@emotion/react
to be used for writing custom-style. See PR#31825.@emotion/css
work as expected when user to write custom styles.What is done
When we call
clsx()
we mind the order in which we provide the arguments.We make sure to put first the internal styles (lower priority) then, the user-defined styles (higher priority).
We also need to extract
classes.root
and apply it in the className instead of forwarding it toButtonBase
because we want to enforce that priority wise:internal styles < classes.root < className
.If you give me the green light, I can apply the same changes on every MUI components.
Best regard,