-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Skip filtering when list of options is loading #33278
Conversation
What problem does this PR solve? It's best to create an issue first. |
Hello |
OK, such a description in the PR is enough. I'm picky about it as in the future, when someone wants to find out when a particular line of code was changed, the PR description and comments will be the only thing to guide them. That's why it's important to have a good description of a change. To make the CI happy, please run |
Yes, I completely understand the need to comment on the change. I made the pull request quickly, I wasn't sure I would be able to contribute. |
The test you've added passes even without your change, so it doesn't correctly verify the problem you're solving. |
packages/mui-base/src/AutocompleteUnstyled/useAutocomplete.test.js
Outdated
Show resolved
Hide resolved
packages/mui-base/src/AutocompleteUnstyled/useAutocomplete.test.js
Outdated
Show resolved
Hide resolved
Please merge or rebase on the latest master. |
Hello |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, thank you! I've updated the logic just a bit, to be more readable. The test looks good now 👍
…een typed