[TimelineConnector] Add support for CSS variables #34002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
new feature
4 tasks
siriwatknp
approved these changes
Aug 22, 2022
ZeeshanTamboli
deleted the
issue/33959-timeline-connector-css-variables
branch
darktasevski
pushed a commit
to darktasevski/material-ui
that referenced
this pull request
Aug 22, 2022
add support for css variables in TimelineConnector component
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
add support for css variables in TimelineConnector component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #33959
CodeSandbox to test in - https://codesandbox.io/s/create-react-app-with-typescript-forked-1ixyq3
If I inspect the classNames on this component with or without CSS vars I don't see any difference, the classNames are not changed without CSS vars. But I guess, there is something of benefit after we added this support. Perhaps a good DX about knowing the design tokens being used instead of hex values?