Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Remove SliderInput export from d.ts #34055

Merged
merged 1 commit into from
Aug 25, 2022
Merged

[Slider] Remove SliderInput export from d.ts #34055

merged 1 commit into from
Aug 25, 2022

Conversation

pieetrus
Copy link
Contributor

@pieetrus pieetrus commented Aug 24, 2022 •
edited by michaldudak
Loading

Fixes #33992

@mui-bot
Copy link

mui-bot commented Aug 24, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against cea8364

@michaldudak michaldudak added component: slider This is the name of the generic UI component, not the React module! typescript package: material-ui Specific to @mui/material labels Aug 24, 2022
@michaldudak michaldudak changed the title [Slider] SliderInput is not exported bug [Slider] Remove SliderInput export from d.ts Aug 24, 2022
michaldudak
michaldudak approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your first contribution to the project!

@pieetrus pieetrus closed this Aug 25, 2022
@michaldudak
Copy link
Member

Why have you discarded this PR?

@pieetrus
Copy link
Contributor Author

Sorry I thought I have to close it to merge it. It's reopened now.

@pieetrus pieetrus reopened this Aug 25, 2022
@michaldudak michaldudak enabled auto-merge (squash) August 25, 2022 11:52
@michaldudak michaldudak merged commit 33420c6 into mui:master Aug 25, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@pieetrus
[Slider] Remove SliderInput export from d.ts (mui#34055)
1394e1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
3 participants
@pieetrus @mui-bot @michaldudak