[FormControlLabel] Add required prop
#34207
Conversation
emlai
force-pushed
the
form-control-label-required
branch
4 times, most recently
from
f7995c8
to
3c7549f
Compare
Netlify deploy previewhttps://deploy-preview-34207--material-ui.netlify.app/ @material-ui/core: parsed: +0.08% , gzip: +0.09% Bundle size report |
emlai
force-pushed
the
form-control-label-required
branch
2 times, most recently
from
b55a9dd
to
c70bc54
Compare
Copied required/asterisk related code from FormLabel.
Similar to `disabled`.
emlai
force-pushed
the
form-control-label-required
branch
2 times, most recently
from
833be78
to
af70a53
Compare
Doesn't make sense for usages such as multiple checkboxes inside a FormControl: https://mui.com/material-ui/react-checkbox/#formgroup
emlai
force-pushed
the
form-control-label-required
branch
from
af70a53
to
24ea31e
Compare
github-actions
bot
added
the
PR: out-of-date
There was a problem hiding this comment.
@emlai The feature is valid to support required prop on FormControlLabel to show the asterisk. The changes look generally good; thanks for the PR. I can review it once the merge conflicts are resolved.
Signed-off-by: Emil Laine <laine.emil@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
|
@ZeeshanTamboli Resolved. |
There was a problem hiding this comment.
I pushed a few refactoring changes. It looks great! Thanks @emlai!
|
On a side note: I am unaware and confused about why required is supported only in the Form Label by inheriting from Form Control. If the Anyway, we can consider this feature since there is currently no way without this PR to show required on the label of the control component. To attach a label to the control, we have to use the |
Resolves #34198.
Adds 'required' state support for
FormControlLabel. Changes mostly copied fromFormLabel.requiredprop from and to thecontrolcomponent, like we do fordisabled.requiredfromFormControl, since it breaks usages such as a required checkbox group: https://mui.com/material-ui/react-checkbox/#formgroup